Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make From impls of NonZero integer const. #90077

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Make From impls of NonZero integer const. #90077

merged 1 commit into from
Oct 21, 2021

Conversation

lilasta
Copy link
Contributor

@lilasta lilasta commented Oct 20, 2021

I also changed the feature gate added to From impls of Atomic integer to const_num_from_num from const_convert.

Tracking issue: #87852

@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2021
@lilasta lilasta changed the title Make the From impls of NonZero integer const. Make From impls of NonZero integer const. Oct 20, 2021
I also changed the feature gate added to `From` impls of Atomic integer to `const_num_from_num` from `const_convert`.
@oli-obk
Copy link
Contributor

oli-obk commented Oct 20, 2021

we are putting adding more const trait impls on hold until T-libs had a chance to discuss it. for more details see #89876

@oli-obk oli-obk added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Oct 20, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Oct 20, 2021

r? @oli-obk

this was discussed in today's libs meeting and we got a green light!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2021

📌 Commit 2fc7806 has been approved by oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned m-ou-se Oct 20, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Oct 20, 2021

@bors rollup

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 21, 2021
Make `From` impls of NonZero integer const.

I also changed the feature gate added to `From` impls of Atomic integer to `const_num_from_num` from `const_convert`.

Tracking issue: rust-lang#87852
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 21, 2021
Rollup of 14 pull requests

Successful merges:

 - rust-lang#86984 (Reject octal zeros in IPv4 addresses)
 - rust-lang#87440 (Remove unnecessary condition in Barrier::wait())
 - rust-lang#88644 (`AbstractConst` private fields)
 - rust-lang#89292 (Stabilize CString::from_vec_with_nul[_unchecked])
 - rust-lang#90010 (Avoid overflow in `VecDeque::with_capacity_in()`.)
 - rust-lang#90029 (Add test for debug logging during incremental compilation)
 - rust-lang#90031 (config: add the option to enable LLVM tests)
 - rust-lang#90048 (Add test for line-number setting)
 - rust-lang#90071 (Remove hir::map::blocks and use FnKind instead)
 - rust-lang#90074 (2229 migrations small cleanup)
 - rust-lang#90077 (Make `From` impls of NonZero integer const.)
 - rust-lang#90097 (Add test for duplicated sidebar entries for reexported macro)
 - rust-lang#90098 (Add test to ensure that the missing_doc_code_examples is not triggered on foreign trait implementations)
 - rust-lang#90099 (Fix MIRI UB in `Vec::swap_remove`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e4cfaa1 into rust-lang:master Oct 21, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 21, 2021
@lilasta lilasta deleted the const_nonzero_from branch December 25, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants